feat(core/render-biblio): render pages field#5252
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends bibliography rendering so localBiblio/biblio entries can include a pages field in rendered references, alongside updating typing and adding a focused spec. It fits into ReSpec’s core reference pipeline by changing how core/render-biblio serializes bibliography entries for the generated References section.
Changes:
- Add
pagesto theBiblioDatatype so bibliography entries can carry page information. - Render
pagesincore/render-bibliooutput and add a small French localization block in the same module. - Extend
tests/spec/core/biblio-spec.jswith a new local bibliography entry and an assertion for page rendering.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/spec/core/biblio-spec.js |
Adds a new local biblio fixture and a spec intended to verify page rendering. |
src/type-helper.d.ts |
Extends the bibliography entry type with an optional pages field. |
src/core/render-biblio.js |
Updates bibliography serialization to emit page info and adds French reference strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcoscaceres
force-pushed
the
feat/4067-biblio-pages
branch
2 times, most recently
from
0fda851 to
bfcf9cb
Compare
marcoscaceres
force-pushed
the
feat/4067-biblio-pages
branch
from
bfcf9cb to
894955a
Compare
When a publisher is followed by pages, use a comma separator instead of a
period ("Publisher, pp. 369-384" not "Publisher. pp. 369-384").
Remove the now-unused endNormalizer/endWithDot helpers. Strengthen the
pages test to assert the full publisher-pages sequence. Add a French
locale test for the reference_not_found string.
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
Yes, all three items are addressed in commit
|
Closes #4067